-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FX-4686] Build compilation step for picasso by parts #4099
[FX-4686] Build compilation step for picasso by parts #4099
Conversation
|
c23f628
to
cf200e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file and the other script files might still be useful. I will remove them before merging
bin/refresh-tsconfig-references.mjs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file will be merged, we need to run it from time to time to avoid need to update references manually. The script is working pretty well, as I tested it many times
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and scary! There are still a few moments to address, but it can be done with a follow-up PR.
* Extraction script * Extract packages with a script * Manually resolve export & type issues * [FX-4686] Build compilation step for picasso by parts (#4099) * Pack packages into picasso * Add compilation for provider and shared * Fix wrong file on main tsconfig --------- Co-authored-by: Mikhail Korolev <[email protected]> * Fix tests for base packages * Fix style imports * Fix jest mocks on base components * Fix circular barrel imports * Fix picasso-forms test errors * Fixed problems with merge with master * Add extra modules to Jest transform * Fix tests on rich text editor * Revert changes to picasso-codemod * Fix Favicon imports * Add build:all dependency to test:unit * Fix spacing & remove leftovers * Adjust Storybook and Cypress to work with split packages (#4117) * Make Cypress work and pass * Make Storybook build * Add module paths to all stories * Add reference ticket to reenable typecheck in storybook * Update Dockerfile * Update package files to fix some issues * Adjust icon generation script * Fix lint errors and build steps * Remove unused typescript check * Adjust build steps for cypress * Fix build script for provider * Fix Dockerfile * Fix Happo * Fix QueryBuilder story * Add codemod and export stubs to avoid breaking changes (#4128) * Test Alert exports field * Fix dist-package mentions * Update build folder * Update build folder in action * Revert all compiled path to dist-package * Fix old dist path in package.json * Fix build script path * Fix build script for non-ts packages * Leftower stories fixed * Export useNotifications from main utils * Remove duplicate package * Add utils stub, cleanup * Add migration codemod * Add typedefs for stubs & fix require calls * Add codemod case for imports from other Picasso packages * Add missing types and utils stub to picasso-forms * Fix Icon spec * Fix Icon paths in stories * Add missing exports from picasso and picasso-forms (#4140) --------- Co-authored-by: Augusto Moura <[email protected]> Co-authored-by: Tomáš Sláma <[email protected]> * Add changeset * Cleanup merge files * Fix broken story * Update alpha workflow --------- Co-authored-by: Augusto Moura <[email protected]> Co-authored-by: Tomáš Sláma <[email protected]>
FX-4686
Description
Add build steps for the typescript compiler.
The changes are on this commit.
The changes are mainly to
package.json
andtsconfig.json
, and are pretty much copy-and-paste, I'm versioning the scripts I was using, but will remove them before merging. They might still be useful before merging the feature branch to masterHow to test
yarn build:package
from root, it should compile all packagesScreenshots
No screenshots
Development checks
props
in component with documentationexamples
for componentBreaking change
PR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?